Skip to content

mixinbooter#250

Open
JornyZipper wants to merge 1 commit into
TeamOpenIndustry:1.12.2-forgefrom
JornyZipper:patch-1
Open

mixinbooter#250
JornyZipper wants to merge 1 commit into
TeamOpenIndustry:1.12.2-forgefrom
JornyZipper:patch-1

Conversation

@JornyZipper

Copy link
Copy Markdown

11.2

@Goldenfield192 Goldenfield192 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The version range needs a small adjustment to match the Maven Version Range Specification – could you update that before merge?
  2. Just a note that MB 11.4 is the latest release; if we're aiming for 11.x, it would be good to target at 11.4+.
  3. MB 11 changed the API, so if we're touching this code now, I’d suggest we drop the 10.x style and switch to the new approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants