Skip to content

2-detector selection effects in Matlab post-processing - #1483

Merged
ilyamandel merged 3 commits into
devfrom
Matlab2det
Aug 20, 2026
Merged

2-detector selection effects in Matlab post-processing#1483
ilyamandel merged 3 commits into
devfrom
Matlab2det

Conversation

@ilyamandel

Copy link
Copy Markdown
Collaborator

No description provided.

@ilyamandel

Copy link
Copy Markdown
Collaborator Author

@pauldisberg -- can you approve this so we don't have too many things hanging around? Or @avigna, since you like Matlab? :) [We are taking a lax attitude to the Matlab code for now, since it's not "official" / documented.]

@pauldisberg pauldisberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Only question I have is concerning the comment about the SNR threshold: "should really be 10 for network, but 8 matches Reed's calculations more closely according to Michael Fulgoni": is this because Reed set this value at 8 and if so why? (but happy to discuss in-person)

@ilyamandel

Copy link
Copy Markdown
Collaborator Author

@pauldisberg : My understanding is that Michael set the threshold to 10.0 as suggested by Reed, but it seems that I am able to best reproduce their results with a threshold of 8.0. Not sure whether it's because of a different waveform model, approximate detector placement, or for some other reason...

@ilyamandel
ilyamandel merged commit 5f7cc50 into dev Aug 20, 2026
2 checks passed
@ilyamandel
ilyamandel deleted the Matlab2det branch August 20, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants