Move exceptions to their own folder#225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception infrastructure reorganisation
ContinuityReplayException,IdentifyException,PlayerAuthException,RequestException,SocketException) moved fromRuntime/Utils/into a dedicatedRuntime/Exceptions/directory, establishing a single, discoverable home for all custom exception typesSafer error-code parsing on
PlayerAuthExceptionandSocketExceptionErrorCodechanged from a lazily-computed method (which parsedMessageon every access) to a property set eagerly in the constructor, ensuring the code is captured once and is available even if the exception is rethrown or its message alteredEnum.Parsereplaced withEnum.TryParseso that unrecognised or malformed error-code strings gracefully fall back toAPI_ERRORinstead of throwing aSystem.ArgumentExceptionat the callerMinor hardening on
ContinuityReplayException_exceptionslist field markedreadonly, signalling immutability after construction and matching standard C# convention