Include error code in OnIdentificationFailed event#224
Merged
Conversation
tudddorrr
force-pushed
the
identification-failed-errorcode
branch
from
July 4, 2026 13:07
761693f to
b008629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception type separation
RequestExceptioninstead ofPlayerAuthException, so auth-specific errors are only raised on auth endpointsGranular identification errors
IdentifyExceptionwith enum codesIDENTIFIER_PROFANITYandIDENTIFIER_TAKENlets game code react to specific failure reasons instead of catching a generic exceptionIdentification failure event enriched
OnIdentificationFailednow passesIdentifyExceptionto subscribers, allowing callers to inspect error details (e.g. profanity/content filtering) rather than getting a bare notification