Fix secret loading for socket message verification#1004
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1004 +/- ##
===========================================
- Coverage 98.27% 98.25% -0.02%
===========================================
Files 427 427
Lines 7110 7111 +1
Branches 964 965 +1
===========================================
Hits 6987 6987
Misses 50 50
- Partials 73 74 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tudddorrr
force-pushed
the
fix-verified-socket-messages
branch
from
July 10, 2026 21:20
6421066 to
d349e3e
Compare
tudddorrr
force-pushed
the
fix-verified-socket-messages
branch
from
July 10, 2026 22:17
d349e3e to
7613f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Socket request signing support
socketLogger.ts: UpdatedlogRequestto strip a leading signature line (separated by newline) before parsing the JSON body whenconn.verifyRequestsis enabled, so the logger correctly extracts the request name from signed messages.socketRouter.ts: Added eager population ofgame.apiSecretduring socket connection validation, ensuring the API secret is available for verifying request signatures at the routing level.