Skip to content

Fix for SDMMC driver on ESP32-P4#572

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
fix-sdmmc-esp32p4
Jul 18, 2026
Merged

Fix for SDMMC driver on ESP32-P4#572
KenVanHoeylandt merged 1 commit into
mainfrom
fix-sdmmc-esp32p4

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

The driver was using the incorrect (read: old) if-defs for a capability check.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated ESP32 SDMMC power-control compilation guards to use SOC_SDMMC_IO_POWER_EXTERNAL. The power-control handle declaration, LDO driver setup, mount-failure cleanup, and unmount cleanup now use the new guard. The LDO channel conversion also uses static_cast<int>. Public interfaces and API wiring remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the ESP32-P4 SDMMC fix and matches the driver-focused changes in the pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-sdmmc-esp32p4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt
KenVanHoeylandt merged commit 5f54f7c into main Jul 18, 2026
60 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the fix-sdmmc-esp32p4 branch July 18, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant