Skip to content

[Maintenance] [XML2PHP] convert service definition configs from XML to PHP - #91

Open
crydotsnake wants to merge 1 commit into
Sylius:1.3from
crydotsnake:maintenance/xml2php-convert-service-definition-configs-from-xml-to-php
Open

[Maintenance] [XML2PHP] convert service definition configs from XML to PHP#91
crydotsnake wants to merge 1 commit into
Sylius:1.3from
crydotsnake:maintenance/xml2php-convert-service-definition-configs-from-xml-to-php

Conversation

@crydotsnake

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #90, partially Sylius/Sylius#18490
License MIT

This PR takes care of migrating the service definition configurations from XML to PHP in preparation for Symfony 8 support.

@crydotsnake
crydotsnake requested a review from a team as a code owner July 22, 2026 05:12
@crydotsnake crydotsnake self-assigned this Jul 22, 2026
@crydotsnake crydotsnake added DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc. labels Jul 22, 2026
return static function (ContainerConfigurator $container) {
$services = $container->services();

$services->set('sylius_wishlist_plugin.data_transformer.wishlist.wishlist_token_value_aware_input_command_data_transformer', WishlistTokenValueAwareInputCommandDataTransformer::class)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PHPStorm it says that the class 'WishlistTokenValueAwareInputCommandDataTransformer' is undefined / does not exist.

Was the class maybe there in the past but has then been deleted, and the person who deleted it forgot to remove the service definition? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant