Prevent empty wishlist creation on page load - #89
Open
jkindly wants to merge 2 commits into
Open
Conversation
Sajgon27
approved these changes
Jul 16, 2026
tomkalon
approved these changes
Jul 21, 2026
TheMilek
approved these changes
Jul 29, 2026
crydotsnake
approved these changes
Jul 29, 2026
crydotsnake
added
Bug
TheMilek
reviewed
Jul 29, 2026
Comment on lines
+79
to
+90
| ```diff | ||
| <service id="sylius_wishlist_plugin.controller.action.list_wishlist_products" class="Sylius\WishlistPlugin\Controller\Action\ListWishlistProductsAction"> | ||
| <argument type="service" id="sylius.context.cart"/> | ||
| <argument type="service" id="form.factory"/> | ||
| <argument type="service" id="twig"/> | ||
| <argument type="service" id="sylius_wishlist_plugin.processor.wishlist_command_processor"/> | ||
| <argument type="service" id="sylius_wishlist_plugin.resolver.wishlists_resolver"/> | ||
| - <argument type="service" id="translator"/> | ||
| - <argument type="service" id="router"/> | ||
| <tag name="controller.service_arguments"/> | ||
| </service> | ||
| ``` |
Member
There was a problem hiding this comment.
Suggested change
| ```diff | |
| <service id="sylius_wishlist_plugin.controller.action.list_wishlist_products" class="Sylius\WishlistPlugin\Controller\Action\ListWishlistProductsAction"> | |
| <argument type="service" id="sylius.context.cart"/> | |
| <argument type="service" id="form.factory"/> | |
| <argument type="service" id="twig"/> | |
| <argument type="service" id="sylius_wishlist_plugin.processor.wishlist_command_processor"/> | |
| <argument type="service" id="sylius_wishlist_plugin.resolver.wishlists_resolver"/> | |
| - <argument type="service" id="translator"/> | |
| - <argument type="service" id="router"/> | |
| <tag name="controller.service_arguments"/> | |
| </service> | |
| ``` |
Not needed
TheMilek
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion of #84
There was still
resolveAndCreate()inListWishlistProductsActionthat was creating empty wishlist when/wishlisturl was visited.