refactor: remove kind from resource class apispec - #1404
Merged
SalimKayal merged 5 commits intoAug 7, 2026
Conversation
leafty
approved these changes
Aug 7, 2026
SalimKayal
force-pushed
the
salimkayal/refactor/remove-kind-from-resource-class-apispec
branch
from
August 7, 2026 11:41
cc479fc to
a2991c0
Compare
Coverage Report for CI Build 31175062154Warning No base build found for commit Coverage: 85.089%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
SalimKayal
merged commit Aug 7, 2026
ecb5aec
into
salimkayal/feat/expend-resource-class-apispec-for-remote-sessions
31 of 33 checks passed
SalimKayal
deleted the
salimkayal/refactor/remove-kind-from-resource-class-apispec
branch
August 7, 2026 15:29
SalimKayal
added a commit
that referenced
this pull request
Aug 11, 2026
* feat: remove redundant kind field from resource-class API spec * refactor: derive resource class local/remote from parent pool * fix: components/renku_data_services/crc/apispec.py * test: update resource pool API tests for removed kind field * refactor: reset QuotaEnforced defaults at apispec level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies #1388
by removing the redundant
kindfield from resource classes.Since every class must match its parent pool's remote kind, exposing
kindon eachclass is unnecessary. Local vs remote is now derived from the pool.
Changes
kindfrom all resource-class schemas and reuseResourceClassPropertiesvia
allOf; regenerateapispec.py.localfromRemoteConfigurationKind;Nonenow means local.pool_kindin validators and from the parent pool indb.py/orm.py.intcast atsession submission in
notebooks/core_sessions.py.