feat: add persisted logs - #1383
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1383.dev.renku.ch |
Coverage Report for CI Build 31171640887Coverage at 85.857% (no base build to compare)Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
leafty
force-pushed
the
leafty/feat-peristed-logs
branch
from
August 4, 2026 13:08
6b3e04c to
210b6b5
Compare
leafty
marked this pull request as ready for review
August 5, 2026 12:44
olevski
requested changes
Aug 7, 2026
olevski
left a comment
Member
There was a problem hiding this comment.
Thanks Flora. Just a few minor things.
olevski
approved these changes
Aug 11, 2026
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for persisted logs from Amalthea sessions and image builds.
Given that persisted logs rely on specific Loki configuration settings, the feature is toggled off by default in the renku helm chart.
/deploy renku=leafty/feat-peristed-logs amalthea-sessions=leafty/feat-run-id-jobs renku-ui=leafty/feat-peristed-logs extra-values=dataService.persistedLogs.enabled=true,dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user