Skip to content

add apps launcher handling - #1356

Merged
wesjdj merged 3 commits into
add-apps-featurefrom
add-apps-launcher-handling
Aug 11, 2026
Merged

add apps launcher handling#1356
wesjdj merged 3 commits into
add-apps-featurefrom
add-apps-launcher-handling

Conversation

@wesjdj

@wesjdj wesjdj commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/deploy renku=add-apps-beta extra-values=apps.enabled=true

@wesjdj
wesjdj requested review from a team, SalimKayal and sgaist as code owners June 18, 2026 09:58
@wesjdj
wesjdj changed the base branch from add-apps-feature to add-apps-list-patch June 18, 2026 10:01
@wesjdj
wesjdj marked this pull request as draft June 18, 2026 10:01
@RenkuBot

Copy link
Copy Markdown
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1356.dev.renku.ch

@coveralls

coveralls commented Jun 24, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28509102417

Warning

No base build found for commit 28a3164 on add-apps-feature.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 86.107%

Details

  • Patch coverage: 20 uncovered changes across 6 files (33 of 53 lines covered, 62.26%).

Uncovered Changes

File Changed Covered %
components/renku_data_services/renku_apps/repository.py 15 5 33.33%
components/renku_data_services/renku_apps/k8s_client.py 6 1 16.67%
components/renku_data_services/session/blueprints.py 13 11 84.62%
components/renku_data_services/project/blueprints.py 7 6 85.71%
components/renku_data_services/project/core.py 3 2 66.67%
components/renku_data_services/session/db.py 6 5 83.33%
Total (8 files) 53 33 62.26%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 32008
Covered Lines: 27561
Line Coverage: 86.11%
Coverage Strength: 1.5 hits per line

💛 - Coveralls

@wesjdj
wesjdj force-pushed the add-apps-list-patch branch from 4661405 to 7d804ae Compare June 29, 2026 10:31
Base automatically changed from add-apps-list-patch to add-apps-feature June 29, 2026 12:03
@wesjdj
wesjdj force-pushed the add-apps-launcher-handling branch from 2e13a12 to ce99c90 Compare June 29, 2026 12:24
@wesjdj
wesjdj marked this pull request as ready for review June 29, 2026 12:40

@olevski olevski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing. But if you prefer we can address everything in future/follow up PRs.

Comment thread components/renku_data_services/renku_apps/repository.py Outdated
Comment thread components/renku_data_services/project/blueprints.py Outdated
@wesjdj
wesjdj force-pushed the add-apps-launcher-handling branch from 9156302 to 97402fd Compare August 10, 2026 12:41
@wesjdj
wesjdj merged commit 2b54ed5 into add-apps-feature Aug 11, 2026
17 of 19 checks passed
@wesjdj
wesjdj deleted the add-apps-launcher-handling branch August 11, 2026 11:03
@RenkuBot

Copy link
Copy Markdown
Contributor

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants