-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(helm): scope resource names by release #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0ca6020
refactor(helm): scope resource names by release name
cmdoret 9a5535e
fix(init): scope openwebui name in init config
cmdoret 5e8de17
feat(helm): helpers fail on long release name
cmdoret 8db3963
fix(helm): populate model values for linting
cmdoret 4b5ef0b
refactor(helm): use fullname helper in model templates
cmdoret 1b8db8f
refactor(envoy): use model fullName instead of dedicated envoy.backen…
cmdoret 38b17da
fix: add default mountpath for existing claims
cmdoret 1441d28
refactor: simplify helpers + add telemetry helper
cmdoret b6fd282
fix(authentik): gate blueprint secret template
cmdoret 8d9e656
refactor(envoy): use fullname helper
cmdoret 5d3928b
refactor(knative): variable for cachePath
cmdoret ecc5880
refactor(init): fullname helper
cmdoret daa9aa8
fix(envoy): gate httproutes
cmdoret 036d638
chore: deduplicate debug values
cmdoret 2826b95
fix(just): pass args before chart in helm template
cmdoret 75fb12b
fix: add missing fullname calls
cmdoret f3c9c0e
doc: note on authentik blueprints scoping
cmdoret e9c9879
refactor(telemetry): shorter prefix for resource names
cmdoret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,25 @@ | ||
| {{- if .Values.envoy.enabled }} | ||
| {{- range $name, $model := .Values.models }} | ||
| {{- $fullname := include "model.fullname" (merge (dict "modelName" $name) $) }} | ||
| {{- if or $model.internal (and (not $model.internal) $model.apiUrl) }} | ||
| --- | ||
| apiVersion: aigateway.envoyproxy.io/v1alpha1 | ||
| kind: BackendSecurityPolicy | ||
| metadata: | ||
| name: backend-security-{{ $name }} | ||
| name: {{ $fullname }}-security | ||
| namespace: {{ $.Release.Namespace }} | ||
| labels: | ||
| app: model-{{ $name }} | ||
| release: {{ $.Release.Name }} | ||
| test: test | ||
| spec: | ||
| type: APIKey | ||
| targetRefs: | ||
| - group: aigateway.envoyproxy.io | ||
| kind: AIServiceBackend | ||
| name: {{ include "envoy.backendName" (merge (dict "modelName" $name) $) }} | ||
| name: {{ $fullname }} | ||
| apiKey: | ||
| secretRef: | ||
| name: vllm-secret-{{ $name }} | ||
| name: {{ $fullname }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| {{- if .Values.openwebui.enabled }} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: init-secret | ||
| name: {{ include "initjob.fullname" . }} | ||
| type: Opaque | ||
| stringData: | ||
| config.toml: | | ||
| [open_webui] | ||
| host = "openwebui.{{ $.Release.Namespace }}.svc.cluster.local:8080" | ||
| host = "{{ include "openwebui.fullname" . }}.{{ $.Release.Namespace }}.svc.cluster.local:8080" | ||
| admin_user = "{{ .Values.openwebui.admin.user | required ".Values.openwebui.admin.user is required" }}" | ||
| admin_email = "{{ .Values.openwebui.admin.email | required ".Values.openwebui.admin.email is required"}}" | ||
| model_ids = [{{ range $name, $model := .Values.models }}"{{ $model.fullName }}",{{ end }}] | ||
| OPENWEBUI_ADMIN_PASSWORD: {{ .Values.openwebui.admin.password | required ".Values.openwebui.admin.password" | quote }} | ||
| {{- end }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.