Skip to content

Add native data view charts - #396

Merged
SudoJacky merged 2 commits into
masterfrom
feat/native-data-views
Aug 10, 2026
Merged

Add native data view charts#396
SudoJacky merged 2 commits into
masterfrom
feat/native-data-views

Conversation

@SudoJacky

Copy link
Copy Markdown
Owner

Summary

  • add a native publish_data_view agent tool with strict Data View v1 validation
  • persist and replay data view artifacts through thread history
  • render interactive ECharts cards with chart, table, CSV, and provenance views
  • support multiple data view publications in a single provider response
  • prevent chart cards from shrinking in the conversation and keep drawer details readable

Why

Agents previously could only describe analytical results in text. This adds a native, persisted visualization path for the app chat experience.

The layout regression had two root causes: conversation grid rows were allowed to shrink, and a broad drawer flex selector also matched artifact content. The fix gives conversation rows intrinsic height and scopes the drawer header layout while making its content independently scrollable.

Validation

  • cargo test -j4 data_view
  • cargo check -j4
  • cargo fmt --all -- --check
  • 140 relevant frontend tests
  • npm run build
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 072c90d996

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/agent/runtime/tool_runtime.rs Outdated
Comment thread src/app-core/chat/dataView.ts
@SudoJacky
SudoJacky merged commit 9954759 into master Aug 10, 2026
1 check passed
@SudoJacky
SudoJacky deleted the feat/native-data-views branch August 10, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant