Bundle create-agent-plugin by default - #393
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 727aeca53f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .plugins | ||
| .get(name) | ||
| .is_some_and(|plugin| bundled::is_bundled_source(&plugin.source_path)) | ||
| { |
There was a problem hiding this comment.
When worker_plugin_uninstall is invoked for an enabled built-in plugin, it calls set_enabled(name, false) and reconciles the runtime at src-tauri/src/desktop_commands/plugins.rs:108-113 before this new guard rejects the removal. The failed uninstall therefore still disables create-agent-plugin, unexpectedly making the migration helper unavailable; the command should check the built-in status before changing enablement.
Useful? React with 👍 / 👎.
1 participant
Summary
create-agent-pluginpackage directly into Tinybotcreate-agent-plugin:migrate-agent-pluginUser impact
Users can migrate a standalone Skill, MCP configuration, or client-specific plugin without downloading and importing the example plugin first. The bundled helper can be disabled, but it cannot be uninstalled accidentally.
Validation
cargo test plugins::store::tests(10 passed)npm test(512 passed)npm run buildcargo checkcargo fmt --all -- --checkgit diff --checkA full local
cargo testrun reached 913 passing tests and 4 environment/timing failures unrelated to this change. Both Windows process-timing failures passed when rerun individually; the other two tests read the existing user-level~/.tinybot/pluginscatalog instead of an isolated fixture.