[test-improver] Fix no-assertion tests in TaskServiceTest (Issue #20)

[github-actions]

🤖 Test Improver — automated AI assistant focused on improving tests.

Goal & Rationale

TaskServiceTest had three tests with zero assertions — they ran the code but verified nothing, silently inflating coverage metrics. Additionally three empty @Disabled("TODO: implement") stubs added noise without value. This addresses part of Issue #20.

Changes

Test	Before	After
testGetTasksByStatus	Calls method, no assertions	Verifies each returned Task has the requested status field
testGetTasksByAssignee	Calls method, no assertions	Verifies empty list for non-existent user; verifies assignee_id filtering correctness
testGetAllTasks	assertNotNull only	Adds assertFalse(isEmpty) — DataInitializer seeds tasks at startup
testAutoAssignTask	Empty @Disabled TODO stub	Removed
testBulkImportWithInvalidData	Empty @Disabled TODO stub	Removed
testConcurrentTaskCreation	Empty @Disabled TODO stub	Removed

Approach

• For getTasksByStatus: call all three status values and use forEach to assert every element has the expected status — catches a filter-bug regression.
• For getTasksByAssignee: create an isolated task with a specific assignee_id, fetch by that ID, assert non-empty list with correct assignee, then delete the task to avoid polluting other tests.
• For getAllTasks: assert non-empty — safe because DataInitializer always seeds data before the Spring context is used.
• Removed three placeholder stubs — when those scenarios need testing, real tests can be added then.

Test Status

Tests run: 35, Failures: 1, Errors: 1, Skipped: 4

Only the 2 pre-existing failures remain (both unchanged):

• DateUtilsTest.testGetQuarter — Bug 🔴 [BUG] getQuarter() returns 0-3 instead of 1-4 (off-by-one bug) #6 (off-by-one in getQuarter())
• TaskServiceTest.testGetTaskStatistics — Bug 🔴 [BUG] ArithmeticException: Division by zero on empty project dashboard #3 (division by zero when no completed tasks)

New assertions in testGetTasksByStatus and testGetTasksByAssignee pass ✅.

Reproducibility

mvn test -B -pl . -Dtest=TaskServiceTest

Generated by Test Improver · 84.2 AIC · ⌖ 9.29 AIC · ⊞ 10.9K · ◷
_{Comment /test-assist to run again}

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/test-improver.md@1c6668b751c51af8571f01204ceffb19362e0f66