fix(a11y): label cluster markers and announce zoom-guard to screen readers - #132
Merged
yakew7 merged 1 commit intoAug 14, 2026
Merged
Conversation
…aders
Cluster markers are divIcons with no accessible name, so a screen-reader
user hears an unlabeled button with no hint of what it represents. Give
each cluster a role=button, tabindex=0, and an aria-label summarizing its
contents ("Cluster of 11 places, mostly SAT centre"), and make Enter/Space
trigger the same zoom-in that click does.
ScrollZoomGuard's hint is aria-hidden and only fires on mouse wheel, so
keyboard users get no equivalent messaging. Add an sr-only note that
announces the keyboard zoom alternative (+/- keys or Ctrl/Cmd + scroll).
Closes StudentSuite#99
Contributor
|
@AryanSingh is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
yakew7
marked this pull request as ready for review
August 14, 2026 07:25
Contributor
Author
|
Noted. The deploy authorization for the studentsuite team is a team-member action that cannot be performed from the fork; this PR has since merged (commit 9c8d0f9). Recording the state here — no further contributor-side action is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Two of the three gaps from the issue:
Cluster markers (
map-view.tsx) aredivIcons with no accessible name. Each cluster now gets:role="button"+tabindex="0"so it's focusable,aria-labelsummarizing its contents (e.g. "Cluster of 11 places, mostly SAT centre"),ScrollZoomGuard hint is
aria-hiddenand mouse-wheel-only. Added ansr-onlynote announcing the keyboard zoom alternative (+/- keys or Ctrl/Cmd + scroll).The third item (desktop zoom-hint dismiss button with a literal "x") no longer exists: the zoom-hint workaround was removed in a06bedd ("fix(map): resolve sidebar density issue, remove zoom hint workaround"), so nothing to change there.
Validation:
tsc --noEmitclean,npm run lintclean,npm run test:unit38/38,npm run buildsucceeds.