Rebalance the fishing business so the boat is worth buying#95
Merged
Conversation
A playtest pass found the business strictly dominated by bait/rod upgrades: workers only ever caught the cheapest species (Minnow, ~$8/day net per worker), so the $500 boat had a ~12-day payback and buying it actually slowed the run. Workers now fish the same waters as the player, landing a rarity-rolled species (fish.rollFishType) instead of a hard-coded Minnow. Per-worker net income roughly triples (~$22/day) and a full crew's boat payback drops to ~4-5 days, making the business a competitive parallel investment rather than a trap. WORKER_FISH_PER_DAY is trimmed 6->5 so the passive income supplements active fishing without overshadowing it (verified by re-running the playtest simulation). Closes #94 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dmccoystephenson
left a comment
dmccoystephenson
left a comment
Member
Author
There was a problem hiding this comment.
Self-review:
- Scope: PASS — business.py engine + its test only.
- Tests-fix: PASS — test_workers_catch_rolled_species_not_just_minnow fails under the old hard-coded-Minnow code; count-based tests still pass against WORKER_FISH_PER_DAY.
- Schema/save-safety: PASS — no persisted-field or schema change (hasBoat/workers unchanged); not a protected path.
- Issue resolution: PASS — workers roll species; balance re-verified via the playtest sim (per-worker
$8->$22, payback ~12->~4-5 days). - Deterministic-tests: PASS — rollFishType patched in the new test. CI: PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the playtest finding in #94: the fishing business was strictly dominated by bait/rod upgrades because workers only ever caught the cheapest species.
src/business/business.py: workers now land a rarity-rolled species (fish.rollFishType) each day instead of a hard-coded Minnow, so crew income tracks the same value distribution as the player's own fishing. Removed the now-unusedWORKER_CATCH_SPECIES.WORKER_FISH_PER_DAYtrimmed 6 → 5 so passive income supplements rather than overshadows active fishing.Balance (re-ran the playtest simulation on the real game code)
$8/day → **$22/day**; full-crew boat payback ~12 days → ~4–5 days.Test plan
python3 -m compileall -q srccleanSDL_VIDEODRIVER=dummy SDL_AUDIODRIVER=dummy python3 -m pytest— 211 passedtest_workers_catch_rolled_species_not_just_minnow(patchesrollFishType); existing count-based business/timeService tests still hold againstWORKER_FISH_PER_DAY.Triage note
Closes #94
🤖 Generated with Claude Code