Validate String argument in Zstd.read_skippable_frame#142
Open
Watson1978 wants to merge 1 commit into
Open
Conversation
rb_read_skippable_frame called RSTRING_PTR/RSTRING_LEN on the argument without going through StringValue(), unlike every other public API. Passing a non-String reinterpreted the object as an RString and dereferenced attacker-influenced fields, causing a SEGV (e.g. a Fixnum argument crashed at an address derived from its immediate value). Add StringValue() so non-String arguments raise TypeError while String-convertible objects (#to_str) keep working. Covered by specs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zstd.read_skippable_framecalledRSTRING_PTR/RSTRING_LENon itsargument without going through
StringValue(), unlike every otherpublic API in this gem (
compress,decompress,write_skippable_frame,streaming compress/decompress all do).
Passing a non-String therefore reinterpreted the object as an
RStringand dereferenced its
ptr/lenfields, leading to a crash. For example aFixnumargument crashed at an address derived from its immediate value:Fix
Add
StringValue(input_value);at the top ofrb_read_skippable_frame,matching the other entry points. Non-String arguments now raise
TypeError, whileString-convertible objects (#to_str) keep working.Tests
Added specs to
spec/zstd-skippable_frame_spec.rb:nil,Integer,Symbol,Array,Object) raiseTypeError#to_strare still acceptedFull suite passes (
66 examples, 0 failures).🤖 Generated with Claude Code