Regionized World Storage - #60
Open
Biquaternions wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a
GenericWorldDataandTickWorldSchedulerclasses, analogous to Folia'sRegionizedWorldDataandTickRegionSchedulerrespectively.For this to work,

TickThread.ServerLevelTickThreadnow receives aServerLevelas an argument in its constructor and stores it as a final variable.currentlyTickingLevelis no longer assigned here, as it always holds the same value (each world has its own independent thread).This implementation fixes two issues:
ignoreBlockEntityUpdatesrandomly ignores block updates in other worlds.shouldSignal.The new

TickWorldSchedulerallows retrieving the world data without relying inThreadLocal, it retrieves the world local signal handler and hopper optimization flags, or fallbacks to the main thread ones if any is called outside the world tick.