ci: add central lessons governance - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the missing central-lessons and protected-delivery controls identified by the
spec-kitaudit under central issue #12.The repository previously had no lessons evidence guard, no central guidance in
AGENTS.md, no security/lessons PR-template sections, and no scheduled advanced CodeQL run. The accompanying live ruleset work protectsmainwith pull-request and current-head check requirements.PR #3 is merged and its deterministic shell-workflow test fix is now on
main. The current net diff for this PR is governance controls only.Testing
uv run specify --help— not applicable; CLI runtime behavior is unchanged.uv run pytest tests/test_lessons_evidence_guard.py tests/test_workflow_run_without_project.py -q: 14 passed on macOS/Python 3.14.uvx ruff check scripts/check-lessons-evidence.py tests/test_lessons_evidence_guard.py tests/test_workflow_run_without_project.py.actionlint .github/workflows/codeql.yml .github/workflows/lessons-evidence.yml.zizmor --pedantic .github/workflows/codeql.yml .github/workflows/lessons-evidence.yml: no findings.gitleaks detect --no-banner --no-git --source . --redact --exit-code 1: no leaks.Security Review Evidence
AGENTS.md, PR template, advanced CodeQL workflow, lessons workflow/guard, and guard tests.security-events: write.main; the live ruleset initially enforces all existing stable checks.Lessons Learned
SoloSentryOrg/github-enterprise-management-solosentry/docs/lessons-learned/register.json.docs/lessons-learned/pubsub-image-factory-migration-2026-06in the central governance repository.LL-0002: the test and CodeQL failures were root-caused before further fix-forward.LL-0003: the repository retains one authoritative advanced CodeQL workflow and does not add a duplicate readiness layer.LL-0004: live default-setup, inherited security configuration, ruleset, and current-head check names were read back through GitHub APIs.LL-0007; this PR performs no branch/worktree cleanup.AI Disclosure
Codex performed the repository audit, live GitHub configuration readback, control implementation, secure workflow review, test execution, and PR preparation.