New build#296
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates build and test tooling to better accommodate the new @uvdsl/solid-oidc-client-browser authn dependency during packaging, with the goal of improving Jest compatibility when this package is consumed by other libraries.
Changes:
- Adjust Webpack externals/output settings (including disabling
publicPathauto-detection) and add externals for the new authn library. - Change TypeScript build to emit declarations only; adjust post-build cleanup accordingly.
- Update Jest/Babel configuration to better handle ESM dependencies in
node_modules(includingimport.metatransforms).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.mjs | Adds OIDC client externals; tweaks output/publicPath and optimization settings for bundling behavior. |
| package.json | Switches build-js to declaration-only emit; adds Babel plugin dependency; extends postbuild cleanup. |
| package-lock.json | Locks babel-plugin-transform-import-meta dependency. |
| jest.config.mjs | Allows transforming select ESM node_modules packages; broadens moduleNameMapper for OIDC client mocks. |
| babel.config.mjs | Adds babel-plugin-transform-import-meta plugin for Jest/Babel transforms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+25
| '@uvdsl/solid-oidc-client-browser': { | ||
| commonjs: '@uvdsl/solid-oidc-client-browser', | ||
| commonjs2: '@uvdsl/solid-oidc-client-browser', | ||
| amd: '@uvdsl/solid-oidc-client-browser', | ||
| root: 'SolidOidcClientBrowser' | ||
| }, | ||
| '@uvdsl/solid-oidc-client-browser/core': { | ||
| commonjs: '@uvdsl/solid-oidc-client-browser/core', | ||
| commonjs2: '@uvdsl/solid-oidc-client-browser/core', | ||
| amd: '@uvdsl/solid-oidc-client-browser/core', | ||
| root: 'SolidOidcClientBrowserCore' | ||
| } |
| output: { | ||
| path: path.resolve(process.cwd(), 'dist'), | ||
| filename: 'solid-logic.js', | ||
| publicPath: '', |
| output: { | ||
| path: path.resolve(process.cwd(), 'dist'), | ||
| filename: 'solid-logic.min.js', | ||
| publicPath: '', |
| output: { | ||
| path: path.resolve(process.cwd(), 'dist'), | ||
| filename: 'solid-logic.esm.js', | ||
| publicPath: '', |
| output: { | ||
| path: path.resolve(process.cwd(), 'dist'), | ||
| filename: 'solid-logic.esm.min.js', | ||
| publicPath: '', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a better handling of the new authn lib when packaging. It makes jest tests work in other libs.