feat(scan): add --reach-retain-facts-file to keep the reachability report (1.1.124)#1372
Merged
Merged
Conversation
…port (1.1.124) By default `socket scan create --reach` deletes the `.socket.facts.json` report from the scan directory after a successful scan. The new `--reach-retain-facts-file` flag opts out of that cleanup so the report can be inspected, with a clear warning that the file must be deleted before the next tier 1 scan: a stale facts file is picked up as a pre-generated input and would make those results unreliable.
Martin Torp (mtorp)
force-pushed
the
feature/reach-retain-facts-file
branch
from
3ff4bbb to
e09b5b3
Compare
Martin Torp (mtorp)
requested review from
Benjamin Barslev Nielsen (barslev) and
Jeppe Fredsgaard Blaabjerg (jfblaa)
and removed request for
Jeppe Fredsgaard Blaabjerg (jfblaa)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Benjamin Barslev Nielsen (barslev)
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes, shipped together as
1.1.124:--reach-retain-facts-fileflag onsocket scan create --reach(the tier 1 reachability path).15.5.0→15.5.4.--reach-retain-facts-fileBy default, after a successful
socket scan create --reach, the CLI deletes the.socket.facts.jsonreachability report that the analysis writes into the scan directory. Some users want to keep that file afterwards (e.g. to inspect or debug the reachability output), which isn't possible today. This flag opts out of the post-scan cleanup so the report is left in place..socket.facts.jsonis removed after a successful scan (failed scans already leave it for debugging).--reach-retain-facts-file(flag on): the file is kept.The flag's help text and the changelog carry an explicit warning:
Changes
reachRetainFactsFileflag in the sharedreachability-flags.mts(the--reach-*namespace) and on theReachabilityOptionstype, threaded through the scan-create / scan-reach / CI / GitHub paths..socket.facts.jsoncleanup inhandle-create-new-scan.mtson the new flag.@coana-tech/clifrom15.5.0to15.5.4(package.json+pnpm-lock.yaml). For details on what's in this Coana release, see the Coana Changelogs.1.1.123→1.1.124and added aCHANGELOG.mdentry covering both changes.--helpsnapshots.Verification
pnpm check:tsc✅pnpm check:lint✅--helpsnapshots rebuilt and passing with Coana15.5.4inlined.Docs
User-facing documentation (CLI reference + tier 1 reachability guide) for the new flag is being updated separately in
socketdev/docs.