This PR adds support for the new callback feature #9
Merged
Conversation
mmmarinho
approved these changes
Jul 8, 2026
mmmarinho
left a comment
Member
There was a problem hiding this comment.
Seems ok, if it doesn't work well please adjust.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @mmmarinho
This PR adds support for the new callback feature. The modifications include a new protected member
std::function<void()> control_loop_callback_and three new public methods.Now, a concrete implementation of
RobotDrivercan set a callback function to be executed in the main control loop handled byRobotDriverROS.For instance, in the constructor, the user can define a callback to publish IMU data
Kind regards,
Juancho