Skip to content

Refactor Accessories Helper: Introduce new configuration structure and add option to highlight duplicate accessories - #2601

Open
Toosiii wants to merge 10 commits into
SkyblockerMod:mainfrom
Toosiii:skyblocker-26.1.2-custom
Open

Refactor Accessories Helper: Introduce new configuration structure and add option to highlight duplicate accessories#2601
Toosiii wants to merge 10 commits into
SkyblockerMod:mainfrom
Toosiii:skyblocker-26.1.2-custom

Conversation

@Toosiii

@Toosiii Toosiii commented Jul 29, 2026

Copy link
Copy Markdown

I made a Button where you see if you have any duplicate accessories in your accessorie Bag

Minecraft Screenshot 2026 07 29 - 14 10 27 47 ![Uploading Min Minecraft Screenshot 2026 07 29 - 14 10 35 33 Minecraft Screenshot 2026 07 29 - 14 10 41 68 Minecraft Screenshot 2026 07 29 - 14 11 09 97 ecraft Screenshot 2026.07.29 - 14.10.30.97.png…]()

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 29, 2026

@viciscat viciscat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • That green color doesn't look very good and is hard on the eyes. Just don't higlight if it's unique
  • Make the higlight a bit more transparent, can barely see the items
  • You broke code formatting a lot (missing indentations in quite a few places)
  • You broke one of the existing features (highlighting the existing accessory when hovering an upgrade in the widget)
  • Please don't modify de_de.json. Changing things other than the english file causes the translations website to lock up

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jul 30, 2026
Toosiii and others added 5 commits July 31, 2026 11:42
made Dupes more transperent
formatted the code
I think I fixed the existing feature?
* some more storage overlay things

* spotless

* remember backpack should only work with the storage overlay

* Fix punctuation

* also search tooltip

---------

Co-authored-by: Aaron <51387595+AzureAaron@users.noreply.github.com>
Currently translated at 7.5% (140 of 1848 strings)

Translation: Skyblocker/Skyblocker
Translate-URL: https://translate.hysky.de/projects/Skyblocker/skyblocker/en_CA/

Co-authored-by: Aaron <51387595+AzureAaron@users.noreply.github.com>
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jul 31, 2026
@Toosiii

Toosiii commented Jul 31, 2026

Copy link
Copy Markdown
Author
Base Profile Screenshot 2026 07 31 - 09 38 42 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants