Skip to content

Fix chat filters missing formatting in action bar - #2582

Open
LJNeon wants to merge 2 commits into
SkyblockerMod:mainfrom
LJNeon:chat-filter-action-bar-fix
Open

Fix chat filters missing formatting in action bar#2582
LJNeon wants to merge 2 commits into
SkyblockerMod:mainfrom
LJNeon:chat-filter-action-bar-fix

Conversation

@LJNeon

@LJNeon LJNeon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

When chat filters are disabled or show as toasts, messages have formatting as expected:
image
image
But formatting from components sent to the action bar is ignored. This results in chat filters that redirect to the action bar losing all coloring in a very noticeable (and ugly IMO) way:
image

That's because player.sendOverlayMessage(msg) is just a wrapper that calls hud.setOverlayMessage(msg, false) where false indicates colors shouldn't be rendered. So this PR directly calls hud.setOverlayMessage(msg, true) instead to render colors:
image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jul 25, 2026
@AzureAaron AzureAaron added the bug Something isn't working label Jul 26, 2026
@AzureAaron AzureAaron added this to the 6.9.0 milestone Jul 26, 2026

@kevinthegreat1 kevinthegreat1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, but I don't think this makes sense. The second parameter, animateOverlayMessageColor, is only used here, which doesn't seem to have anything to do with formatting.
Image

@kevinthegreat1 kevinthegreat1 added question Further information is requested and removed reviews needed This PR needs reviews labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants