Fix chat filters missing formatting in action bar - #2582
Open
LJNeon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When chat filters are disabled or show as toasts, messages have formatting as expected:



But formatting from components sent to the action bar is ignored. This results in chat filters that redirect to the action bar losing all coloring in a very noticeable (and ugly IMO) way:
That's because

player.sendOverlayMessage(msg)is just a wrapper that callshud.setOverlayMessage(msg, false)wherefalseindicates colors shouldn't be rendered. So this PR directly callshud.setOverlayMessage(msg, true)instead to render colors: