[MS-1520] Don't send empty moduleIds in DeviceConfigurationUpdatedEvent

[BurningAXE]

JIRA ticket
Will be released in: 2026.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2026.2.0

• If selected moduleIds on the device are empty, it generates an event with an empty array (instead of null) for moduleIds but doesn't list them in tokenized fields (as there's nothing tokenized in there). However, the backend validation trips as it sees a path that should be tokenized but is not listed as such.

Notable changes

• When moduleIds are empty - set the value to null instead of empty array so that JSON conversion omits it

Testing guidance

• Login with a project configured with module partitioning but don't select modules
• Go to settings and change language
• Sync
• Backend should not complain

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

Fixes an event-sync validation issue where DeviceConfigurationUpdatedEvent could serialize downSyncModules as an empty array (rather than omitting the field), causing the backend to detect an untokenized tokenizable path.

Changes:

• Normalize downSyncModules to null during setTokenizedListFields(...) when the tokenized list is empty, preventing empty-array serialization.
• Add unit tests to ensure both null and empty-list module selections result in downSyncModules == null after tokenization.
• Add an event-to-API mapping test to ensure downSyncModules is omitted from the serialized ApiEvent when no modules are selected.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
infra/events/src/main/java/com/simprints/infra/events/event/domain/models/DeviceConfigurationUpdatedEvent.kt	Normalizes empty tokenized module list back to null to avoid emitting an empty array that triggers backend tokenization validation.
infra/events/src/test/java/com/simprints/infra/events/event/domain/models/DeviceConfigurationUpdatedEventTest.kt	Adds coverage for setTokenizedListFields to ensure empty module lists remain/are converted to null.
infra/event-sync/src/test/java/com/simprints/infra/eventsync/event/usecases/MapDomainEventToApiUseCaseTest.kt	Verifies API JSON omits downSyncModules (and produces no tokenizedFields) when modules are not selected.

[luhmirin-s]

Wouldn't it be safer to fix it in TokenizeEventPayloadFieldsUseCase:23 by filtering/skipping any fields with empty lists?

That way we would not need to remember to apply the same fix for any list field in any future events.

[BurningAXE]

Good idea! I'll rework.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

infra/events/src/test/java/com/simprints/infra/events/event/domain/models/DeviceConfigurationUpdatedEventTest.kt:73

• Test name says setTokenizableFields_* but the test actually calls setTokenizedListFields(...), which makes the intent misleading when reading failures. Rename the test to match the API under test.

    fun setTokenizableFields_keepsModuleIdsNullWhenMapHasNoModuleIds() {

infra/events/src/test/java/com/simprints/infra/events/event/domain/models/DeviceConfigurationUpdatedEventTest.kt:61

• Test name says setTokenizableFields_* but the test actually calls setTokenizedListFields(...), which makes the intent misleading when reading failures. Rename the test to match the API under test.

This issue also appears on line 73 of the same file.

    fun setTokenizableFields_keepsExistingModuleIdsWhenMapHasNoModuleIds() {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud