Skip to content

Fix 'extentions' package typo - #1761

Open
BurningAXE wants to merge 3 commits into
MS-1519-consolidate-isValidGuidfrom
fix-extentions-typo
Open

Fix 'extentions' package typo#1761
BurningAXE wants to merge 3 commits into
MS-1519-consolidate-isValidGuidfrom
fix-extentions-typo

Conversation

@BurningAXE

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.3.0

Notable changes

  • A package was wrongly named 'extentions' instead of 'extensions'
  • To make it worse in tests there were both 'extentions' and 'extensions' :)
  • This PR renames the packages and all imports to the correct spelling so that my OCD can let me sleep tonight

Testing guidance

  • Everything should work as before (famous last words for the second time today - I'm really pushing it!)

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Jul 28, 2026
@BurningAXE
BurningAXE requested a review from Copilot July 28, 2026 16:26
@BurningAXE
BurningAXE changed the base branch from main to MS-1519-consolidate-isValidGuid July 28, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the misspelled com.simprints.core.tools.extentions package to com.simprints.core.tools.extensions across app and test code, and updates dependent imports/usages. In addition, it extends the confirm response flow to optionally return CoSync “subject actions” data via ActionResponse.ConfirmActionResponse and the client-api response mappers.

Changes:

  • Rename/update imports from core.tools.extentionscore.tools.extensions across multiple modules and migration tests.
  • Add subjectActions to ActionResponse.ConfirmActionResponse and map it into intent extras for LibSimprints/CommCare clients.
  • Replace the old String.isValidGuid() extension test with new StringUtilsTest coverage under core.tools.utils.

Reviewed changes

Copilot reviewed 73 out of 73 changed files in this pull request and generated no comments.

Show a summary per file
File Description
infra/ui-base/src/main/java/com/simprints/infra/view/imagecapture/CaptureTargetView.kt Update import to extensions package
infra/ui-base/src/main/java/com/simprints/infra/view/imagecapture/CaptureProgressView.kt Update import to extensions package
infra/ui-base/src/main/java/com/simprints/infra/uibase/camera/qrscan/QrCodeDetector.kt Update coroutine extensions imports to extensions
infra/orchestrator-data/src/main/java/com/simprints/infra/orchestration/data/ActionResponse.kt Add subjectActions to confirm response model
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigrationTest.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration9To10Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration7To8Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration6to7Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration5to6Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration4to5Test.kt Update cursor extension imports to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration3to4Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration2to3Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration1to2Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration16to17Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration15to16Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration14to15Test.kt Update cursor extension import to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration13to14Test.kt Update cursor extension imports to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration12to13Test.kt Update cursor extension imports to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration11to12Test.kt Update cursor extension imports to extensions
infra/events/src/test/java/com/simprints/infra/events/event/local/migrations/EventMigration10to11Test.kt Update cursor extension imports to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration9to10.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration7to8.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration6to7.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration5to6.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration3to4.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration2to3.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration1to2.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration16to17.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration15to16.kt Update cursor extension import to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration14to15.kt Update cursor extension imports to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration12to13.kt Update cursor extension imports to extensions
infra/events/src/main/java/com/simprints/infra/events/event/local/migrations/EventMigration10to11.kt Update cursor extension import to extensions
infra/event-sync/src/test/java/com/simprints/infra/eventsync/event/usecases/MapDomainEventToApiUseCaseTest.kt Update sealed-when helper import to extensions
infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/remote/models/ApiSuspiciousIntentPayload.kt Update map conversion import to extensions
infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/remote/models/ApiInvalidIntentPayload.kt Update map conversion import to extensions
infra/core/src/test/java/com/simprints/core/tools/utils/StringUtilsTest.kt Add tests for GUID validation + randomUUID()
infra/core/src/test/java/com/simprints/core/tools/utils/MapUtilKtTest.kt Update imports to extensions package
infra/core/src/test/java/com/simprints/core/tools/extentions/StringExtTest.kt Remove old misspelled-package test
infra/core/src/test/java/com/simprints/core/tools/extensions/SharedPreferencesExtTest.kt Update import to extensions package
infra/core/src/test/java/com/simprints/core/tools/extensions/RectFExtTest.kt Update import to extensions package
infra/core/src/test/java/com/simprints/core/tools/extensions/ListExtTest.kt Fix test package declaration to extensions
infra/core/src/test/java/com/simprints/core/tools/extensions/FlowExtTest.kt Fix test package declaration to extensions
infra/core/src/test/java/com/simprints/core/tools/extensions/ActivityExtTest.kt Update import to extensions package
infra/core/src/main/java/com/simprints/core/tools/extentions/String.ext.kt Remove old misspelled-package GUID extension
infra/core/src/main/java/com/simprints/core/tools/extensions/SharedPreferences.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/RectF.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Map.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/List.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Flow.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Float.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Cursor.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Coroutines.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Context.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Any.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/tools/extensions/Activity.ext.kt Fix file package declaration to extensions
infra/core/src/main/java/com/simprints/core/CoreModule.kt Update imports to extensions package
infra/auth-store/src/main/java/com/simprints/infra/authstore/domain/LoginInfoStore.kt Update SharedPreferences extension import
id/src/main/java/com/simprints/id/Application.kt Update deviceHardwareId import
fingerprint/connect/src/main/java/com/simprints/fingerprint/connect/screens/issues/serialentrypair/SerialEntryPairFragment.kt Update keyboard extension import
fingerprint/connect/src/main/java/com/simprints/fingerprint/connect/screens/controller/ConnectScannerControllerFragment.kt Update permission extension imports
fingerprint/capture/src/main/java/com/simprints/fingerprint/capture/screen/FingerprintCaptureViewModel.kt Update list extension import
feature/select-subject/src/main/java/com/simprints/feature/selectsubject/screen/SelectSubjectViewModel.kt Switch GUID validation import to utils
feature/matcher/src/main/java/com/simprints/matcher/screen/MatchFragment.kt Update permission/settings extension imports
feature/login/src/main/java/com/simprints/feature/login/screens/qrscanner/QrScannerFragment.kt Update permission extension import
feature/login-check/src/main/java/com/simprints/feature/logincheck/usecases/ReportActionRequestEventsUseCase.kt Update JSON-map extension import
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ResetExternalCredentialsInSessionUseCase.kt Switch GUID validation import to utils
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchFragment.kt Update keyboard extension import
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanqr/ExternalCredentialScanQrFragment.kt Update permission extension imports
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt Update permission extension imports
feature/dashboard/src/test/java/com/simprints/feature/dashboard/settings/syncinfo/usecase/ObserveSyncInfoUseCaseTest.kt Update mockkStatic target for Flow extensions
feature/dashboard/src/test/java/com/simprints/feature/dashboard/settings/syncinfo/SyncInfoViewModelTest.kt Update mockkStatic target for Flow extensions
feature/dashboard/src/main/java/com/simprints/feature/dashboard/settings/syncinfo/usecase/ObserveSyncInfoUseCase.kt Update flow-change extension import
feature/dashboard/src/main/java/com/simprints/feature/dashboard/settings/syncinfo/moduleselection/ModuleSelectionFragment.kt Update keyboard extension import
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/OdkResponseMapperTest.kt Update confirm-response construction for new field
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapperTest.kt Add tests for confirm response CoSync mapping
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapperTest.kt Add tests for confirm response CoSync mapping
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/ActionToIntentMapperTest.kt Update confirm-response construction for new field
feature/client-api/src/test/java/com/simprints/feature/clientapi/ClientApiViewModelTest.kt Add tests covering confirm-response CoSync generation gating
feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapper.kt Append CoSync extras for confirm responses
feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapper.kt Append CoSync extras for confirm responses
feature/client-api/src/main/java/com/simprints/feature/clientapi/ClientApiViewModel.kt Generate subjectActions for confirm responses when applicable
face/capture/src/main/java/com/simprints/face/capture/usecases/BitmapToByteArrayUseCase.kt Update dp-to-px extension import
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/views/DashedCircularProgress.kt Update dp-to-px extension import
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/views/CameraTargetOverlay.kt Update dp-to-px extension import
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackViewModel.kt Update RectF area extension import
face/capture/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt Update permission/flash extension imports

@BurningAXE
BurningAXE marked this pull request as ready for review July 28, 2026 16:33
@BurningAXE
BurningAXE requested review from a team, TristramN, alex-vt, alexandr-simprints, luhmirin-s, meladRaouf and ybourgery and removed request for a team July 28, 2026 16:33
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
48.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@BurningAXE
BurningAXE force-pushed the MS-1519-consolidate-isValidGuid branch from 9444146 to e108666 Compare July 29, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants