Return subjectActions on ConfirmIdentity if externalCredential was linked - #1759
Open
BurningAXE wants to merge 1 commit into
Open
Return subjectActions on ConfirmIdentity if externalCredential was linked#1759BurningAXE wants to merge 1 commit into
BurningAXE wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CoSync “subjectActions” payload support to Confirm Identity responses so client integrations can receive subject action data when an external credential is linked.
Changes:
- Extend
ActionResponse.ConfirmActionResponseto include an optionalsubjectActionsfield. - Generate
subjectActionsinClientApiViewModel.handleConfirmResponse()only when anexternalCredentialexists and a valid selected GUID is present. - Map
subjectActionsinto response bundles for LibSimprints and CommCare, with new/updated unit tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| infra/orchestrator-data/src/main/java/com/simprints/infra/orchestration/data/ActionResponse.kt | Adds subjectActions to ConfirmActionResponse model. |
| feature/client-api/src/main/java/com/simprints/feature/clientapi/ClientApiViewModel.kt | Conditionally generates and returns subjectActions on confirm responses. |
| feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapper.kt | Appends CoSync subject actions into LibSimprints confirm response extras. |
| feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapper.kt | Appends CoSync subject actions into CommCare confirm response bundle. |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/ClientApiViewModelTest.kt | Adds confirm-path tests for when CoSync is/isn’t generated. |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapperTest.kt | Adds coverage for mapping confirm responses with CoSync data. |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapperTest.kt | Adds coverage for mapping confirm responses with CoSync data. |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/OdkResponseMapperTest.kt | Updates confirm response construction for new parameter. |
| feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/ActionToIntentMapperTest.kt | Updates confirm response construction for new parameter. |
| import com.simprints.core.livedata.LiveDataEvent | ||
| import com.simprints.core.livedata.LiveDataEventWithContent | ||
| import com.simprints.core.livedata.send | ||
| import com.simprints.core.tools.extentions.isValidGuid |
Contributor
Author
There was a problem hiding this comment.
This will be addressed in a separate PR app-wide.
BurningAXE
marked this pull request as ready for review
July 28, 2026 14:32
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
July 28, 2026 14:33
BurningAXE
force-pushed
the
feature/cosync+mfid
branch
from
July 28, 2026 16:41
2ab2952 to
ee13130
Compare
|
alexandr-simprints
approved these changes
Jul 28, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.3.0
Notable changes
Testing guidance
Additional work checklist