Raise SigmaValueError for non-finite SigmaNumber values - #526
Merged
thomaspatzke merged 1 commit intoAug 11, 2026
Conversation
SigmaNumber.__post_init__ converted float('inf'), float('-inf') and
float('nan') via int() without handling the resulting OverflowError,
crashing rule parsing with a raw OverflowError instead of a
SigmaValueError. This is reachable from rule files, since .inf/.nan are
valid YAML floats (detection.py:151 passes them to sigma_type()).
Convert the value to float first and reject non-finite numbers with
SigmaValueError('Invalid number'). Also catch OverflowError so oversized
integers that overflow float conversion are reported as invalid numbers
instead of raising unhandled.
thomaspatzke
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SigmaNumber.post_init converted float('inf'), float('-inf') and float('nan') via int() without handling the resulting OverflowError, crashing rule parsing with a raw OverflowError instead of a SigmaValueError. This is reachable from rule files, since .inf/.nan are valid YAML floats (detection.py:151 passes them to sigma_type()).
Convert the value to float first and reject non-finite numbers with SigmaValueError('Invalid number'). Also catch OverflowError so oversized integers that overflow float conversion are reported as invalid numbers instead of raising unhandled.