Reserve-tree migration for 5-bus fixtures; required base_current on TModelHVDCLine - #124
Merged
Conversation
ConstantReserve/VariableReserve -> OnlineReserve (keyword form where the positional order changed), ReserveDemandCurve -> OnlineReserve carrying its demand curve on `variable`, VariableReserveNonSpinning -> OfflineReserve.
TModelHVDCLine now requires base_current (A); its per-unit impedances are normalized against a current base. Set to S_base/V_base = 100 MVA / 500 kV = 200 A for the 10-bus AC/DC system.
Static fixture: keyword-form MarketBidCost (offer-curve defaults replace the removed Nothing positional signatures). TS fixture: restore the original intent with MarketBidTimeSeriesCost - every field references an attached series by key - replacing the dead static-cost-plus-loose-series shape left behind when PSY removed the TimeSeriesData set_variable_cost! overload. Unblocks deleting PSB's psy6_compat.jl shims.
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixture updates for the psy6 reserve-tree refactor and cost/struct API changes:
data_5bus_pu.jl:ConstantReserve/VariableReserve->OnlineReserve, ORDC carries its demand curve onvariable,VariableReserveNonSpinning->OfflineReserve.data_10bus_ac_dc_pu.jl:base_current = 200.0A on the three DC lines (S_base/V_base = 100 MVA / 500 kV); the field is now required.generation_cost_function_data.jl: keyword-formMarketBidCostfor the static fixture; the TS fixture now builds a realMarketBidTimeSeriesCost(every field key-references an attached series), replacing the dead static-cost-plus-loose-series shape and unblocking removal of PSB'spsy6_compat.jl.Pairs with the PSY changes on
jd/schema_matchingand the PSBrh/service_refactorbranch. Verified: affected systems force-build from raw, and the full POM suite is green against these fixtures.🤖 Generated with Claude Code