Feat/rust time series store - #153
Open
jd-lara wants to merge 4 commits into
Open
Conversation
# Conflicts: # Project.toml
A serialized System is a directory (document plus time-series sidecar), not a single file, so `make_system_filename` becomes `make_system_dirname` and drops the `.json` extension. Delete `load_system`. It called `IS.InfrastructureSystemsContainer(file)` — a constructor on an abstract type, so it could never have run — and its only reference was a commented-out line in the emulation test. IOM cannot rebuild a System from the bundle anyway; that needs PSY, and PowerAnalytics' `load_outputs` covers the round-trip. `IS.get_uuid` no longer exists: components and supplemental attributes are identified by an integer IS id, and the System's UUID is the only one left. So `DeviceModel`/`ServiceModel` key their outages by `Int`, and the two system-UUID reads in `problem_outputs.jl` go through the existing domain-neutral `get_system_uuid` seam rather than reaching for a deleted IS function. Drop the UUID check from `set_source_data!` for the same reason: resolving a domain system's UUID needs PSY, which IOM does not depend on. The check moves to callers that can make it — PowerAnalytics' two-argument `load_outputs`. Pin PowerCoreOpenAPIModels to feat/infrastore-integration, matching the IS branch: `TimeSeriesAssociation` there drops time_series_uuid/metadata_uuid and adds quantity_type/unit_system, which is the shape IS now writes.
Contributor
|
Performance Results This branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR to InfrastructureOptimizationModels.jl, please take note of the following when making a PR:
Check the contributor guidelines