[2026-01] Fix preact entry points; validate package.json integrity in CI (publint + attw) - #4648
Open
henryStelle wants to merge 1 commit into
Open
[2026-01] Fix preact entry points; validate package.json integrity in CI (publint + attw)#4648henryStelle wants to merge 1 commit into
henryStelle wants to merge 1 commit into
Conversation
2 tasks
- Add a typesVersions entry for ./preact so its types resolve under moduleResolution 'node' (node10), matching checkout/preact and customer-account/preact. - Remove the dead ./point-of-sale/preact exports entry, which points at files that are never built or published. - Add publint and @arethetypeswrong/cli as devDependencies with package:publint / package:attw scripts. - Run both tools in CI after a package build so entry-point regressions fail the PR (attw ignores false-cjs, which is pre-existing and harmless for bundled extension code). Backport of e62b515 (#4645) to 2026-01. Assisted-By: devx/ffe30952-4960-4347-b0e5-48d8697405ff
henryStelle
force-pushed
the
henry/backport-preact-entry-points-2026-01
branch
from
August 21, 2026 20:37
2007ec8 to
df830c8
Compare
henryStelle
marked this pull request as ready for review
August 21, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
typesVersionsentry for./preactso@shopify/ui-extensions/preacttypes resolve under TypeScript's legacymoduleResolution: "node"(node10), matching the existingcheckout/preactandcustomer-account/preactentries../point-of-sale/preactexport, which points at files that are never built or published.moduleResolutionmode (attw ignoresfalse-cjs, a pre-existing.d.ts-vs-.d.mtssplit that is harmless for bundled extension code).Why
import "@shopify/ui-extensions/preact"is required for signal-driven re-rendering, but its types don't resolve under node10 module resolution, which the generated extension templates use. With the fixes reverted, publint fails on the missingpoint-of-sale/preactfiles and attw reports a node10 resolution failure for./preact; with them applied, both checks pass.Backport of #4645 to
2026-01.