[2025-10] Fix preact entry points; validate package.json integrity in CI (publint + attw) - #4647
Open
henryStelle wants to merge 1 commit into
Open
[2025-10] Fix preact entry points; validate package.json integrity in CI (publint + attw)#4647henryStelle wants to merge 1 commit into
henryStelle wants to merge 1 commit into
Conversation
2 tasks
henryStelle
marked this pull request as ready for review
August 21, 2026 20:35
henryStelle
marked this pull request as draft
August 21, 2026 20:36
- Add a typesVersions entry for ./preact so its types resolve under moduleResolution 'node' (node10), matching checkout/preact and customer-account/preact. - Remove the dead ./point-of-sale/preact exports entry, which points at files that are never built or published. - Add publint and @arethetypeswrong/cli as devDependencies with package:publint / package:attw scripts. - Run both tools in CI after a package build so entry-point regressions fail the PR (attw ignores the pre-existing, harmless false-cjs rule). Backport of e62b515 (#4645) to 2025-10. Assisted-By: devx/7ecfa2dd-8bc7-47b2-a5ad-0ec47a969483
henryStelle
force-pushed
the
henry/backport-preact-entry-points-2025-10
branch
from
August 21, 2026 20:37
437b7f2 to
fdb216b
Compare
henryStelle
marked this pull request as ready for review
August 21, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
typesVersions["*"]entry for./preactso@shopify/ui-extensions/preacttypes resolve under TypeScript's legacymoduleResolution: "node"(node10), matching the existingcheckout/preactandcustomer-account/preactentries../point-of-sale/preactexportsentry, which points at files that are never built or published; POS extensions should use the generic@shopify/ui-extensions/preactentry point.@arethetypeswrong/cli) validation to CI so entry-point regressions fail the PR, with attw ignoring the pre-existing, harmlessfalse-cjsrule (ESM types declared as.d.tsrather than.d.mts).Why
import "@shopify/ui-extensions/preact"is required for signal-driven re-rendering, but its types do not resolve under node10 module resolution, which the generated extension templates use. This branch matters in particular because extensions-templates pins@shopify/ui-extensions@2025.10.x. Verified locally: with the two package.json fixes reverted, publint errors on the missingpoint-of-sale/preactfiles and attw reports node10 resolution failure for./preact; with the fixes applied, both checks pass.Backport of #4645 to
2025-10.