[2026-04] Fix preact entry points; validate package.json integrity in CI (publint + attw) - #4646
Open
henryStelle wants to merge 1 commit into
Open
[2026-04] Fix preact entry points; validate package.json integrity in CI (publint + attw)#4646henryStelle wants to merge 1 commit into
henryStelle wants to merge 1 commit into
Conversation
- Add a typesVersions entry for ./preact so its types resolve under moduleResolution 'node' (node10), matching checkout/preact and customer-account/preact. - Remove the dead ./point-of-sale/preact exports entry, which points at files that are never built or published. - Add publint and @arethetypeswrong/cli as devDependencies with package:publint / package:attw scripts, and run them in CI after the build (attw with --ignore-rules false-cjs for the pre-existing .d.ts vs .d.mts split, harmless for bundled extension code). - Add a patch changeset. Backport of e62b515 (#4645) to 2026-04. Assisted-By: devx/6b10e95a-83bf-4991-ad7d-82f1c1f5ace6
2 tasks
henryStelle
marked this pull request as ready for review
August 21, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
typesVersions["*"]entry for./preactso@shopify/ui-extensions/preacttypes resolve undermoduleResolution: "node"(node10), matching the existingcheckout/preactandcustomer-account/preactentries../point-of-sale/preactexport, which points at files that are never built or published.publintand@arethetypeswrong/cliin CI after the build to validate that every entry point ships in the npm tarball and that types resolve under everymoduleResolutionmode (attw ignoresfalse-cjs, a pre-existing.d.ts-vs-.d.mtssplit that is harmless for bundled extension code).Why
import "@shopify/ui-extensions/preact"is required for signal-driven re-rendering, but its types fail to resolve under node10 module resolution, which the generated extension templates use. With the fixes reverted, both new CI checks fail (publint errors on the missingpoint-of-sale/preactfiles; attw reports node10 resolution failure for./preact); with them applied, both pass.Backport of #4645 to
2026-04.