Fix trailing comma in en.default.schema.json#97
Open
hersfang wants to merge 1 commit into
Open
Conversation
The trailing comma after the "text_style" object makes the locale schema file invalid JSON, which breaks strict JSON parsers and translation tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes a trailing comma after the
text_styleobject inlocales/en.default.schema.jsonthat makes the file invalid JSON.Why
Strict JSON parsers (e.g.
JSON.parse, Python'sjson) reject the file as shipped, which breaks translation tooling and any pipeline that round-trips locale files. Shopify's own parser tolerates it, so the bug is silent in the editor but surfaces the moment the file is processed externally.Change
One character:
},→}on line 75. All other locale files already parse cleanly.🤖 Generated with Claude Code