Skip to content

add find tool formatters#1020

Open
LasmarKhalifa wants to merge 1 commit into
07-02/pi-tool-formatter-grepfrom
07-02/pi-tool-formatter-find
Open

add find tool formatters#1020
LasmarKhalifa wants to merge 1 commit into
07-02/pi-tool-formatter-grepfrom
07-02/pi-tool-formatter-find

Conversation

@LasmarKhalifa

@LasmarKhalifa LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Closes #1028

LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 2eeb38f to eba0fd6 Compare July 3, 2026 14:50
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from 86c73f5 to 3b64e5c Compare July 3, 2026 14:50
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from eba0fd6 to 96d8a9b Compare July 3, 2026 15:06
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from 3b64e5c to 10a0676 Compare July 3, 2026 15:06
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 96d8a9b to 554abfb Compare July 3, 2026 15:30
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch 2 times, most recently from 3799ee2 to 919a175 Compare July 3, 2026 16:02
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch 2 times, most recently from 8a4b6f3 to 621fd97 Compare July 3, 2026 16:12
@LasmarKhalifa LasmarKhalifa marked this pull request as ready for review July 3, 2026 16:30

@mathiusj mathiusj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find formatter looks good.

Comment thread lib/roast/cogs/agent/providers/pi/messages/tool_result_message.rb
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 621fd97 to dd0821d Compare July 10, 2026 15:23
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch 2 times, most recently from 2ad8c53 to 74166f6 Compare July 10, 2026 15:50
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from dd0821d to 1d2092c Compare July 10, 2026 15:50
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from 74166f6 to f877583 Compare July 10, 2026 16:13
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 1d2092c to eef857c Compare July 10, 2026 16:13
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from f877583 to f55f3f1 Compare July 10, 2026 16:33
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from eef857c to b9177ad Compare July 10, 2026 16:33
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from f55f3f1 to d0bc73d Compare July 10, 2026 16:38
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from b9177ad to 9857673 Compare July 10, 2026 16:38
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-find branch from 9857673 to 5cbb42c Compare July 10, 2026 18:11
@LasmarKhalifa LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-grep branch from d0bc73d to 5beb941 Compare July 10, 2026 18:11
@LasmarKhalifa LasmarKhalifa linked an issue Jul 13, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pi format_find tool implementation

2 participants