Ajout d'un cooldown de téléportation lors d'un combat#1340
Draft
ar1hurgit wants to merge 1 commit into
Draft
Conversation
iambibi
changed the title
iambibi
requested changes
Jul 11, 2026
iambibi
left a comment
iambibi
left a comment
Member
There was a problem hiding this comment.
Beaucoup de choses à changer et à justifier
Si ta PR est prete a etre review d'ailleurs mets la ouverte et pas en draft
Comment on lines
+118
to
+120
| if (!PlayerUtils.sendFadeTitleTeleport(player, loc)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!PlayerUtils.sendFadeTitleTeleport(player, loc)) { | |
| return; | |
| } | |
| if (!PlayerUtils.sendFadeTitleTeleport(player, loc)) return; |
Comment on lines
+34
to
+36
| if (!PlayerUtils.sendFadeTitleTeleport(player, spawnLocation)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!PlayerUtils.sendFadeTitleTeleport(player, spawnLocation)) { | |
| return; | |
| } | |
| if (!PlayerUtils.sendFadeTitleTeleport(player, spawnLocation)) return; |
Comment on lines
+41
to
+43
| if (!PlayerUtils.sendFadeTitleTeleport(target, spawnLocation)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!PlayerUtils.sendFadeTitleTeleport(target, spawnLocation)) { | |
| return; | |
| } | |
| if (!PlayerUtils.sendFadeTitleTeleport(target, spawnLocation)) return; |
Comment on lines
+14
to
+16
| if (!(event.getEntity() instanceof Player player)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!(event.getEntity() instanceof Player player)) { | |
| return; | |
| } | |
| if (!(event.getEntity() instanceof Player player)) return; |
Comment on lines
+18
to
+20
| if (!(event.getDamager() instanceof Player)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!(event.getDamager() instanceof Player)) { | |
| return; | |
| } | |
| if (!(event.getDamager() instanceof Player)) return; |
| public static void sendFadeTitleTeleport(Player player, Location location) { | ||
| if (PlayerSettingsManager.getPlayerSettings(player.getUniqueId()).getSetting(SettingType.TELEPORT_TITLE_FADE)) { | ||
|
|
||
| private static final long TELEPORT_DELAY_TICKS = 14L; |
Member
There was a problem hiding this comment.
pourquoi faire une constante pour ça? enleve ça
Comment on lines
+42
to
+45
| Duration.ofMillis(1000), | ||
| Duration.ofMillis(500), | ||
| Duration.ofMillis(500) | ||
| ) |
Member
There was a problem hiding this comment.
pourquoi mettre des entiers difficiles a composer au lieu d'avant
Comment on lines
+32
to
+34
| if (!canTeleport(player)) { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!canTeleport(player)) { | |
| return false; | |
| } | |
| if (!canTeleport(player)) return false; |
Comment on lines
+64
to
+66
| if (remainingSeconds == 0) { | ||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (remainingSeconds == 0) { | |
| return true; | |
| } | |
| if (remainingSeconds == 0) return true; |
Comment on lines
+136
to
+198
| def serverJar = file("run/paper.jar") | ||
| def paperUrl = "https://fill-data.papermc.io/v1/objects/8600cc3b91ea38d7e836d562550b31d0fa3ed785d14dffc1a6d9dc1d36c21fa5/paper-26.2-56.jar" | ||
|
|
||
| tasks.register("runDevServer") { | ||
| dependsOn shadowJar | ||
|
|
||
| doLast { | ||
| mkdir("run") | ||
| mkdir("run/plugins") | ||
|
|
||
| if (!serverJar.exists()) { | ||
| println("Téléchargement de Paper...") | ||
|
|
||
| new URL(paperUrl).withInputStream { input -> | ||
| serverJar.withOutputStream { output -> | ||
| output << input | ||
| } | ||
| } | ||
| } | ||
|
|
||
| copy { | ||
| from shadowJar.archiveFile | ||
| into "run/plugins" | ||
| rename { "OpenMC.jar" } | ||
| } | ||
|
|
||
| def javaExe = javaToolchains.launcherFor { | ||
| languageVersion = JavaLanguageVersion.of(targetJavaVersion) | ||
| }.get().executablePath.asFile.absolutePath | ||
|
|
||
| def process = new ProcessBuilder( | ||
| javaExe, | ||
| "-Xms2G", | ||
| "-Xmx2G", | ||
| "-jar", | ||
| serverJar.name, | ||
| "--nogui" | ||
| ) | ||
| .directory(file("run")) | ||
| .redirectErrorStream(true) | ||
| .start() | ||
|
|
||
| Thread.start { | ||
| process.inputStream.eachLine { | ||
| println(it) | ||
| } | ||
| } | ||
|
|
||
| Thread.start { | ||
| def writer = new BufferedWriter(new OutputStreamWriter(process.outputStream)) | ||
| System.in.withReader { reader -> | ||
| String line | ||
| while ((line = reader.readLine()) != null) { | ||
| writer.write(line) | ||
| writer.newLine() | ||
| writer.flush() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| process.waitFor() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
finalement enleve ça c'est dégeu
Member
|
Ici tu as pas encore fais les changements |
Author
|
okok oe je vois |
iambibi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR
Ajout d'un cooldown de combat qui bloque les téléportations tant que le joueur est encore en combat, et ajout d'une task Gradle
unDevServer pour lancer un serveur Paper local avec le plugin compilé.
Ce que ça rajoute
unDevServer pour lancer un serveur Paper local et copier le jar du plugin dans
un/plugins.
Issue liée
Validation avant merge
Notes de test