fix(TextArea): correct value type in onChange/onInput callback data - #4542
Open
Khushighosh wants to merge 1 commit into
Open
fix(TextArea): correct value type in onChange/onInput callback data#4542Khushighosh wants to merge 1 commit into
Khushighosh wants to merge 1 commit into
Conversation
|
@Khushighosh is attempting to deploy a commit to the Semantic UI Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4542 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 186 186
Lines 3463 3463
=======================================
Hits 3447 3447
Misses 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4464
The onChange/onInput callbacks for TextArea were typed with
data: TextAreaProps, which allowsvalueto benumber | string | undefined— reflecting valid input values. But at runtime, the callback always returns the actual typed string, so this made consumers cast/narrowdata.valueunnecessarily.This PR introduces a
TextAreaOnChangeDatatype that narrowsvaluetostringspecifically for the callback's returned data, without changingStrictTextAreaProps.valueitself.