Turn the remerger into a service - #79
Open
rdettai-sk wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts mature-merge (“remerger”) configuration so that, when no explicit day-span is provided, the system attempts mature merges successively across multiple timestamp day spans (0, 1, then 2), and updates CLI parsing/help + unit tests accordingly.
Changes:
- Change
split_timestamp_days_rangefromu8toOption<u8>and default it toNoneto enable multi-pass day-span attempts. - Add a day-span candidate sequence (0/1/2) when unset and run mature merge passes per candidate.
- Update merge planning to require an explicit day-span (tests updated to set
Some(0)/Some(1)explicitly) and update CLI arg behavior/documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| quickwit/quickwit-indexing/src/mature_merge.rs | Makes day-span optional, adds multi-pass execution over candidate day spans, and updates the per-index merge entrypoint signature/tests. |
| quickwit/quickwit-indexing/src/mature_merge_plan.rs | Requires an explicit day-span during planning and updates tests to pass Some(days) explicitly. |
| quickwit/quickwit-cli/src/tool.rs | Updates CLI help text and parsing to support optional day-span config (unset => multi-pass behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nothing fancy, just run everynight at 4am.
How was this PR tested?
Describe how you tested this PR.