fix(seuxdr): trust TLS CA in agent register client#5
Merged
Conversation
The manager serves its API/TLS server cert on the mTLS registration port (:8081) so agents can verify it, but InitmTLSClient only trusted the mTLS CA (server-ca-crt.pem). Agent registration failed with 'certificate signed by unknown authority'. Also append the TLS CA (certs/server-ca.crt) to the register client's RootCAs pool.
There was a problem hiding this comment.
Pull request overview
This PR fixes agent registration TLS verification by ensuring the agent’s mTLS registration client trusts the manager’s API/TLS CA, preventing “certificate signed by unknown authority” failures during /api/register.
Changes:
- Appends the manager API/TLS CA (
certs/server-ca.crt) into the registration client’sRootCAspool inInitmTLSClient. - Adds in-code rationale explaining why both the mTLS CA and the API/TLS CA must be trusted on the registration port.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+102
to
+104
| if tlsCACert, tlsErr := commSvc.EmbeddedFiles.ReadFile("certs/server-ca.crt"); tlsErr == nil { | ||
| caCertPool.AppendCertsFromPEM(tlsCACert) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager serves its API/TLS server cert on the mTLS registration port (:8081) so agents can verify it, but InitmTLSClient only trusted the mTLS CA (server-ca-crt.pem). Agent registration failed with 'certificate signed by unknown authority'. Also append the TLS CA (certs/server-ca.crt) to the register client's RootCAs pool.