[codex] Relax startup catch-up waits for Windows CI#123
Merged
Conversation
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Release PR #122 is blocked by Windows CI shard 6/8. The failing test waits for
wait_for_startup_catch_up, which includes the detached transcript ingest task. That task can legally take up to 20s before its timeout guard completes, so shorter waits are flaky on loaded Windows runners.Verification
cargo fmt --checkcargo test mcp_server_owns_watcher_and_refreshes_token_map_on_change --test mcp_handler_testcargo test wait_for_startup_catch_up_waits_for_transcript_ingest_flag --test mcp_handler_testcargo test two_mcps_on_same_project_coordinate_via_sync_lock --test multi_mcp_coordination_test