fix(decoder): normalize delimiter names in decode options - #14
Open
gstarr-cigna wants to merge 1 commit into
Open
fix(decoder): normalize delimiter names in decode options#14gstarr-cigna wants to merge 1 commit into
gstarr-cigna wants to merge 1 commit into
Conversation
The CLI passes delimiter names ('comma'/'tab'/'pipe') as
default_delimiter, but DecoderOptions used the value directly as the
split character, so tabular rows were never split on the literal string
'comma'. Normalize names to their character form, matching what
EncoderOptions already does, so CLI decode round-trips correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toon <file>.toon -d(and any caller passing a named delimiter) decodes tabular arrays into garbage:Root cause
The CLI passes the argparse choice strings
'comma'/'tab'/'pipe'asdefault_delimiter, butDecoderOptionsstored the value unchanged and used it directly as the row-splitting character. Rows were split on the literal 5-character string"comma", which never matches, so each row came back as one field.The encoder already normalizes these names (
EncoderOptions,toon/encoder.py); the decoder did not.Fix
Mirror the encoder's normalization in
DecoderOptions(toon/decoder.py): map'comma'→,,'tab'→\t,'pipe'→|. Character forms continue to work unchanged.Added
test_decode_delimiter_name_normalizationcovering both named and character delimiter forms. Full suite: 137 passed, 1 skipped.