Skip to content

fix: resolve CI build failure and screenshot viewing issues - #34

Merged
SayanthRock merged 2 commits into
mainfrom
fix-build-and-screenshot-issues-13259558032000593592
Jul 29, 2026
Merged

fix: resolve CI build failure and screenshot viewing issues#34
SayanthRock merged 2 commits into
mainfrom
fix-build-and-screenshot-issues-13259558032000593592

Conversation

@SayanthRock

@SayanthRock SayanthRock commented Jul 29, 2026

Copy link
Copy Markdown
Owner

User description

Resolved two issues reported:

  1. CI build failure: The build.gradle.kts explicitly declared a debug configuration that attempted to load debug.keystore which doesn't exist in the repo (it's ignored). This was causing the assembleDebug CI check to fail with a missing keystore error. I updated the script to fallback to the default Android debug signing properties.
  2. Screenshot viewing issues: Some devices or global policies might block screenshots via FLAG_SECURE. Added window.clearFlags(WindowManager.LayoutParams.FLAG_SECURE) in MainActivity's onCreate() to clear this flag and explicitly ensure the system does not block screenshots.

PR created automatically by Jules for task 13259558032000593592 started by @SayanthRock


CodeAnt-AI Description

Fix Android builds and allow screenshots

What Changed

  • Debug and fallback release builds now use the standard Android debug signing configuration instead of requiring a missing keystore file
  • Screenshots can be captured and viewed from the app, including on devices or policies that previously blocked them

Impact

✅ Reliable CI debug builds
✅ Successful release fallback builds without a bundled keystore
✅ Screenshots available for app review and sharing

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Bug Fixes
    • Improved release build signing behavior when the release keystore is unavailable.
    • Fixed screenshot viewing by allowing screenshots to be captured in the app.

Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 29, 2026 06:17
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@devloai

devloai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

@codeant-ai

codeant-ai Bot commented Jul 29, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR de4117a Jul 29, 2026 · 06:17 06:19

@performance-testing-bot

Copy link
Copy Markdown

Unable to locate .performanceTestingBot config file

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Android signing fallback configuration now reuses debug signing values, while MainActivity explicitly clears the secure-window flag during creation.

Changes

Signing configuration

Layer / File(s) Summary
Release and debug signing behavior
app/build.gradle.kts
Release builds copy signing properties from the debug configuration when the release keystore is missing, and the debug build type relies on the default debug signing configuration.

Activity window flags

Layer / File(s) Summary
Activity secure-window handling
app/src/main/java/com/example/MainActivity.kt
MainActivity imports WindowManager and clears FLAG_SECURE during onCreate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main fixes: CI build failure and screenshot viewing issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-build-and-screenshot-issues-13259558032000593592

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jul 29, 2026

@ai-coding-guardrails ai-coding-guardrails Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got 1 comment for you to consider

Risk: 🟢 Low

Risk analysis

The highest scoring dimension is security_impact due to the unconditional clearing of WindowManager.LayoutParams.FLAG_SECURE in MainActivity.kt, which may override device or enterprise security policies and expose sensitive content. The blast_radius is moderate because the change affects all users of the app, and reversibility is low since the change is simple to revert but could require a hotfix if it causes unintended security exposure.

Reviewed with 🤟 by Zenable

Comment thread app/src/main/java/com/example/MainActivity.kt
@ai-coding-guardrails ai-coding-guardrails Bot added the zenable/risk:low Zenable assessed this PR as LOW risk. label Jul 29, 2026
Comment thread app/build.gradle.kts
Comment thread app/src/main/java/com/example/MainActivity.kt
Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/build.gradle.kts`:
- Around line 35-39: Update the release signing configuration in
app/build.gradle.kts so buildTypes.release cannot fall back to
signingConfigs.debug when KEYSTORE_PATH, STORE_PASSWORD, or KEY_PASSWORD is
unavailable. Fail the release build during configuration or signing setup when
release credentials are missing, or route debug-signed artifacts through a
separate build type/flavor with a distinct application ID.
- Around line 35-39: Update the release signing fallback around
signingConfigs.getByName("debug") to use the CI-generated ./debug.keystore path
explicitly for storeFile, while retaining the debug signing credentials and
existing release behavior when my-upload-key.jks or KEYSTORE_PATH are available.

In `@app/src/main/java/com/example/MainActivity.kt`:
- Around line 47-48: Gate the window.clearFlags call in MainActivity so
FLAG_SECURE is removed only for recognized debug or screenshot-test build
variants. Preserve the secure default for release and other production-like
variants by leaving the flag unchanged unless the build configuration explicitly
enables screenshot testing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 58507159-ddfb-494d-9e18-9a6ec9f52e94

📥 Commits

Reviewing files that changed from the base of the PR and between a6f6924 and de4117a.

📒 Files selected for processing (2)
  • app/build.gradle.kts
  • app/src/main/java/com/example/MainActivity.kt

Comment thread app/build.gradle.kts
Comment thread app/src/main/java/com/example/MainActivity.kt
@SayanthRock
SayanthRock merged commit ced0830 into main Jul 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files zenable/risk:low Zenable assessed this PR as LOW risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants