refactor(desktop): restore native window chrome#1188
Open
eleboucher wants to merge 1 commit into
Open
Conversation
Member
|
Why? I intentionally made a custom titlebar on windows, so it looks nice and we can have extra functionality, like loading indicator and etc. also could please follow the PR format unless the title is self explanatory for small changes. |
Member
|
Getting rid of it on mac might makes sense, on windows imo its better to have it so we can theme it. On linux, idk. People's setups vary just like... add a toggle or something I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of change
Checklist:
AI disclosure: