Skip to content

Fix Python vector search authentication #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SWORDIntel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Python vector search authentication #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions python/qihse/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@ class DistanceMetric(IntEnum):
]
_lib.qihse_vector_db_add_vectors.restype = ctypes.c_bool

_lib.qihse_auth_init.argtypes = []
_lib.qihse_auth_init.restype = None
_lib.qihse_auth_get_user.argtypes = [ctypes.c_uint32]
_lib.qihse_auth_get_user.restype = ctypes.c_void_p

# Vector search is authorization-aware. Initialize the process-local auth
# context once and retain the pre-seeded operator for local SDK operations.
_lib.qihse_auth_init()
_local_sdk_user = _lib.qihse_auth_get_user(0)
if not _local_sdk_user:
raise RuntimeError("QIHSE failed to initialize the local SDK auth context")

class CVectorQuery(ctypes.Structure):
_fields_ = [
("query_vector", ctypes.POINTER(ctypes.c_float)),
Expand All @@ -84,6 +96,7 @@ class CVectorQuery(ctypes.Structure):
("distance_metric", ctypes.c_int),
("metadata_filter", ctypes.c_void_p),
("metadata_filter_opaque", ctypes.c_void_p),
("user", ctypes.c_void_p),
]

class CVectorResult(ctypes.Structure):
Expand Down Expand Up @@ -253,6 +266,7 @@ def search(
c_query.distance_metric = metric.value
c_query.metadata_filter = None
c_query.metadata_filter_opaque = None
c_query.user = _local_sdk_user

out_results = (CVectorResult * top_k)()

Expand Down
24 changes: 24 additions & 0 deletions python/tests/test_vector_search_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import os
import tempfile

import numpy as np

from qihse.core import DistanceMetric, VectorDB


def test_vector_search_supplies_authenticated_user():
with tempfile.TemporaryDirectory() as temp_dir:
path = os.path.join(temp_dir, "auth-search.qdb")
vectors = np.eye(4, dtype=np.float32)

with VectorDB.create(path, dims=4) as database:
database.add_vectors(vectors, ids=[10, 11, 12, 13])
database.build_graph()
results = database.search(
vectors[2],
k=2,
metric=DistanceMetric.COSINE,
)

assert results
assert results[0].id == 12
Loading