refactor artifact downloading - #101
Open
cbarbian-sap wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case archiveTypeTar: | ||
| tarReader := tar.NewReader(reader) | ||
| for { | ||
| header, err := tarReader.Next() |
Comment on lines
+284
to
+317
| for _, file := range zipReader.File { | ||
| path := filepath.Clean(file.Name) | ||
| fullPath := filepath.Join(targetPath, path) | ||
| switch { | ||
| case file.FileInfo().Mode().IsDir(): | ||
| if err := os.MkdirAll(fullPath, 0755); err != nil { | ||
| return err | ||
| } | ||
| case file.FileInfo().Mode().IsRegular(): | ||
| if err := os.MkdirAll(filepath.Dir(fullPath), 0755); err != nil { | ||
| return err | ||
| } | ||
| fileReader, err := file.Open() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if err := func() error { | ||
| defer fileReader.Close() | ||
| outFile, err := os.Create(fullPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return func() error { | ||
| defer outFile.Close() | ||
| _, err := io.Copy(outFile, fileReader) | ||
| return err | ||
| }() | ||
| }(); err != nil { | ||
| return err | ||
| } | ||
| default: | ||
| return fmt.Errorf("encountered unknown zip type while downloading URL: %v in %s", file.FileInfo().Mode(), path) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor artifact downloading: add some smart logic to auto-detect