test(destination): make BDD subaccount creation idempotent#172
Open
jplbrun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BDD integration tests for destination creation at subaccount level fail if a previous test run fails or is interrupted before cleanup, leaving the destination on the BTP subaccount. The next run then attempts to create it again and receives an error, causing the test to fail for reasons unrelated to the code under test.
This PR fixes that by replicating the idempotent cleanup pattern already used in other steps, attempting to delete the destination before creating it. The delete is wrapped in a try/except so it is silently skipped if the destination does not exist yet, making the step safe for both first runs and reruns.
Related Issue
N/A
Type of Change
Please check the relevant option:
How to Test
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
None
Additional Notes
N/A