Skip to content

feat(auditlog_ng): support destination based configuration#169

Open
betinacosta wants to merge 13 commits into
mainfrom
feat/support-destination-based-config
Open

feat(auditlog_ng): support destination based configuration#169
betinacosta wants to merge 13 commits into
mainfrom
feat/support-destination-based-config

Conversation

@betinacosta

Copy link
Copy Markdown
Member

Description

The AuditLog NG module currently requires callers to explicitly provide endpoint, deployment_id, and namespace when calling create_client. In SPII-based deployments, these values are stored in a Destination (with tenant-specific fragments) following the ALS SPII v3.0.0 provisioning lifecycle. This change allows create_client to resolve these parameters automatically from a Destination, reducing boilerplate and avoiding misconfiguration.

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

from sap_cloud_sdk.core.auditlog_ng import create_client

client = create_client(
    destination_name="AuditLogV3_Destination",
    destination_instance="default"
)

print(f"Client created: {client}")
print(f"  endpoint:      {client._config.endpoint}")
print(f"  deployment_id: {client._config.deployment_id}")
print(f"  namespace:     {client._config.namespace}")

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

If this PR introduces breaking changes, please describe:

  • What breaks
  • Migration path for users
  • Alternative approaches considered

Additional Notes

Add any additional context, screenshots, or information that would help reviewers.

@betinacosta betinacosta requested a review from a team as a code owner June 16, 2026 18:22
@betinacosta betinacosta marked this pull request as draft June 16, 2026 18:23
@betinacosta betinacosta changed the title Feat: support destination based configuration feat: support destination based configuration Jun 16, 2026
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
@betinacosta betinacosta marked this pull request as ready for review June 16, 2026 19:10

@cassiofariasmachado cassiofariasmachado left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! I've added some comments

Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
Comment thread src/sap_cloud_sdk/core/auditlog_ng/user-guide.md Outdated
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
Comment thread src/sap_cloud_sdk/core/auditlog_ng/__init__.py Outdated
Comment thread pyproject.toml Outdated
@cassiofariasmachado cassiofariasmachado changed the title feat: support destination based configuration feat(auditlog_ng): support destination based configuration Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants