Skip to content

Small zeroization fix #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emil-wire wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small zeroization fix #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions x-wing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,17 @@ fn expand_key(
shaker.update(sk);
let mut expanded: Shake256Reader = shaker.finalize_xof();

let seed = read_from(&mut expanded).into();
#[allow(unused_mut)]
let mut seed = read_from(&mut expanded).into();
let (sk_m, pk_m) = MlKem768::from_seed(&seed);

let sk_x = read_from(&mut expanded);
let sk_x = StaticSecret::from(sk_x);
#[cfg(feature = "zeroize")]
seed.zeroize();

#[allow(unused_mut)]
let mut sk_x_raw = read_from(&mut expanded);
let sk_x = StaticSecret::from(sk_x_raw);
#[cfg(feature = "zeroize")]
sk_x_raw.zeroize();
let pk_x = PublicKey::from(&sk_x);

(sk_m, sk_x, pk_m, pk_x)
Expand Down