fix: 배포 헬스체크를 로그 기반 완료 신호 감지 방식으로 변경 (prod)#199
Merged
Conversation
고정 타임아웃(15초+10회x10초)으로 성공/실패를 판단하던 방식이 OTel 에이전트 부팅 시간 증가로 성공한 배포를 실패로 오판하는 문제가 있어, 프로세스 생존 여부(kill -0)와 로그의 "Started ServerApplication" 신호 감지로 대체. dev 브랜치(PR #196)에서 이미 검증된 수정을 prod가 쓰는 main 브랜치에도 반영.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 배경
main브랜치의deploy.sh가 여전히 고정 타임아웃(15초+10회x10초) 기반 헬스체크를 쓰고 있었음변경 사항
scripts/deploy.shkill -0 $PID(프로세스 생존 확인) + 로그의Started ServerApplication신호 감지로 성공/실패 판단 로직 교체영향 범위
appspec.yml의AfterInstall훅 타임아웃(300초)은 main/dev 동일하여 별도 조정 불필요Test Plan
bash -n scripts/deploy.sh문법 검증🤖 Generated with Claude Code